Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iter_archive #3066

Merged
merged 9 commits into from
Oct 18, 2021
Merged

Add iter_archive #3066

merged 9 commits into from
Oct 18, 2021

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Oct 12, 2021

Added the iter_archive method for the StreamingDownloadManager.

It was already implemented in the regular DownloadManager.
Now it can be used to stream from TAR archives as mentioned in #2829

I also updated the food101 dataset as an example.
Any image/audio dataset using TAR archives can be updated to use iter_archive in order to be streamable :)

cc @severo

Fix #2829.

@lhoestq lhoestq marked this pull request as ready for review October 12, 2021 16:26
severo added a commit to huggingface/dataset-viewer that referenced this pull request Oct 13, 2021
See huggingface/datasets#3066
Also:
- encode bytes data as UTF-8 encoded base64 in JSON responses
- use Z standard for dates
- ensure we use the same version of datasets for the datasets and the
code
severo added a commit to huggingface/dataset-viewer that referenced this pull request Oct 13, 2021
See huggingface/datasets#3066
Also:
- encode bytes data as UTF-8 encoded base64 in JSON responses
- use Z standard for dates
- ensure we use the same version of datasets for the datasets and the
code
@lhoestq lhoestq merged commit 0ef629c into master Oct 18, 2021
@lhoestq lhoestq deleted the iter_archive branch October 18, 2021 09:12
mattstern31 added a commit to mattstern31/datasets-server-storage-admin that referenced this pull request Nov 11, 2023
See huggingface/datasets#3066
Also:
- encode bytes data as UTF-8 encoded base64 in JSON responses
- use Z standard for dates
- ensure we use the same version of datasets for the datasets and the
code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants